linux-kernel - Re: [PATCHv2 02/12]posix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091222144851.GS18217@ZenIV.linux.org.uk>
Date:	Tue, 22 Dec 2009 14:48:51 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	liu weni <qingshenlwy@...il.com>
Cc:	chris.mason@...cle.com, joel.becker@...cle.com, cjb@...top.org,
	jmorris@...ei.org, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, onlyflyer@...il.com,
	strongzgy@...il.com
Subject: Re: [PATCHv2 02/12]posix_acl: Add the check items

On Tue, Dec 22, 2009 at 10:31:38PM +0800, liu weni wrote:
> Hi All:
> 
>     I'm sorry for my stupid. I am crazy for fixing this bug.
> And make so much mistake.

Welcome to the club.  It's OK, _everyone_ around here had done that.
Many times.

> Maybe I need cool down and think more.
 
Always a good advice, but in this case it's a bit more specific - if you
see that you are modifying behaviour for some arguments, figure out what
would lead to such arguments and see if that behaviour is intentional ;-)
And if after that you are still not sure whether it's a bug or not, ask the
people involved what the hell had they intended to happen in such-and-such
case (often enough that'll bring variants of "nice catch" - bugs *do* happen).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/