linux-kernel - Re: [PATCH] Drop 80-character limit in checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.0912221607180.21496@twin.jikos.cz>
Date:	Tue, 22 Dec 2009 16:10:44 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Paul Mundt <lethal@...ux-sh.org>
Cc:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Am?rico Wang <xiyou.wangcong@...il.com>,
	Mikulas Patocka <mpatocka@...hat.com>,
	linux-kernel@...r.kernel.org, Alasdair G Kergon <agk@...hat.com>,
	dm-devel@...hat.com
Subject: Re: [PATCH] Drop 80-character limit in checkpatch.pl

On Mon, 21 Dec 2009, Paul Mundt wrote:

> > Example picked totally at random:
> > 
> > 	set_le_ih_k_offset(ih,
> > 			   le_ih_k_offset(ih) +
> > 			   (tb->
> > 			    lbytes <<
> > 			    (is_indirect_le_ih
> > 			     (ih) ? tb->tb_sb->
> > 			     s_blocksize_bits -
> > 			     UNFM_P_SHIFT :
> > 			     0)));
> > 
> > See how everything is nicely aligned to 80 cols?
> > 
> > 
> > Generally, don't look at this function after having a good lunch you want 
> > to keep. You have been warned.
> > 
> This isn't a valid example, as it wasn't written by a human. This is the
> result of Lindent being run blindly on the file and nothing more.
> 
> Try again.

But having hard rule imposed on everyone to stick with 80-char rule makes 
people to do exactly this kind of things (blindly running indent -l80 and 
believing that it makes the code more readable because it is 
CodingStyle-compliant(tm)).

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/