linux-kernel - Re: [PATCH] slab: initialize unused alien cache entry as NULL at alloc_alien

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1261521485.3000.1692.camel@calx>
Date:	Tue, 22 Dec 2009 16:38:05 -0600
From:	Matt Mackall <mpm@...enic.com>
To:	Haicheng Li <haicheng.li@...ux.intel.com>
Cc:	linux-mm@...ck.org, Christoph Lameter <cl@...ux-foundation.org>,
	Pekka Enberg <penberg@...helsinki.fi>, andi@...stfloor.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] slab: initialize unused alien cache entry as NULL at
 alloc_alien_cache().

On Tue, 2009-12-22 at 20:38 +0800, Haicheng Li wrote:

>   	ac_ptr = kmalloc_node(memsize, gfp, node);
>   	if (ac_ptr) {
> +		memset(ac_ptr, 0, memsize);

Please use kzalloc_node here.

I'm not sure what's going on with nr_node_id vs MAX_NUMNODES, so I think
we need to see an answer to Christoph's question before going forward
with this.

-- 
http://selenic.com : development and support for Mercurial and Linux


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/