linux-kernel - Re: [PATCH] e1000: Fix tests of unsigned in e1000_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 22 Dec 2009 15:50:49 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	e1000-devel@...ts.sourceforge.net,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] e1000: Fix tests of unsigned in e1000_tx_map()

On Tue, Dec 15, 2009 at 11:02, Roel Kluin <roel.kluin@...il.com> wrote:
> The variables count and i are unsigned so the (<|>=) 0 tests do not work.
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
>
> This should be all with this pattern.
> As before I wasn't able to test this patch, so please review.
>
>  drivers/net/e1000/e1000_main.c |   10 +++++-----
>  drivers/net/e1000e/netdev.c    |   10 +++++-----
>  drivers/net/igb/igb_main.c     |   10 +++++-----
>  drivers/net/igbvf/netdev.c     |   10 +++++-----
>  drivers/net/ixgb/ixgb_main.c   |   10 +++++-----
>  drivers/net/ixgbe/ixgbe_main.c |   10 +++++-----
>  6 files changed, 30 insertions(+), 30 deletions(-)
>

Thanks Roel, I will add this patch to my queue.  Sorry for the delayed
response, for some odd reason your email got filtered.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/