linux-kernel - Re: [PATCH] slab: initialize unused alien cache entry as NULL at alloc_alien

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B31EC7C.7000302@gmail.com>
Date:	Wed, 23 Dec 2009 11:10:04 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Haicheng Li <haicheng.li@...ux.intel.com>
CC:	Christoph Lameter <cl@...ux-foundation.org>, linux-mm@...ck.org,
	Pekka Enberg <penberg@...helsinki.fi>,
	Matt Mackall <mpm@...enic.com>, andi@...stfloor.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] slab: initialize unused alien cache entry as NULL at
 alloc_alien_cache().

Le 23/12/2009 07:52, Haicheng Li a écrit :
> Christoph & Matt,
> 
> Thanks for the review. Node ids beyond nr_node_ids could be used in the
> case of
> memory hotadding.
> 
> Let me explain here:
> Firstly, original nr_node_ids = 1 + nid of highest POSSIBLE node.
> 
> Secondly, consider hotplug-adding the memories that are on a new_added
> node:
> 1. when acpi event is triggered:
> acpi_memory_device_add() -> acpi_memory_enable_device() -> add_memory()
> -> node_set_online()
> 
> The node_state[N_ONLINE] is updated with this new node added.
> And the id of this new node is beyond nr_node_ids.
> 

Then, this is a violation of the first statement :

nr_node_ids = 1 + nid of highest POSSIBLE node.

If your system allows hotplugging of new nodes, then POSSIBLE nodes should include them
at boot time.

Same thing for cpus and nr_cpus_ids. If a cpu is added, then its id MUST be < nr_cpus_ids
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/