[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4B316B66.2020206@cn.fujitsu.com>
Date: Wed, 23 Dec 2009 08:59:18 +0800
From: Li Zefan <lizf@...fujitsu.com>
To: Peter Zijlstra <peterz@...radead.org>
CC: rostedt@...dmis.org, Ingo Molnar <mingo@...e.hu>,
Frederic Weisbecker <fweisbec@...il.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: Fix lockdep warning in global_clock()
Peter Zijlstra wrote:
> On Tue, 2009-12-22 at 13:17 +0800, Li Zefan wrote:
>
>> Looking into sched_clock.c, seems the only place that can trigger lockdep
>> is the local_irq_* in cpu_clock(), though I'm not sure for architecture-
>> specific sched_clock().
>
> But why would you want to do that? that reduces the lockdep coverage for
> no good reason, just fix up the tracer.
>
Then the proper fix is to use local_irq_* in global_clock(), which
is what this patch does.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists