linux-kernel - Re: [PATCH] Fix tracing infrastructure to support multiple includes when defining CREATE_TRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091223120224.GA6520@hmsreliant.think-freely.org>
Date:	Wed, 23 Dec 2009 07:02:24 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, fweisbec@...il.com, mingo@...hat.com,
	Mathieu Desnoyers <compudj@...stal.dyndns.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] Fix tracing infrastructure to support multiple
	includes when defining CREATE_TRACE_POINTS

On Tue, Dec 22, 2009 at 01:03:59PM -0500, Steven Rostedt wrote:
> On Wed, 2009-12-16 at 11:04 -0500, Neil Horman wrote:
> 
> 
> > +#if !defined(_TRACE_NAPI_H_) || defined(TRACE_HEADER_MULTI_READ)
> >  #define _TRACE_NAPI_H_
> >  
> 
> Ug, I'm still getting panics because of this. I found out that it's
> because napi->dev can be NULL.
> 
> Here's what I did to solve it:
Gahhh, you're right, We had to do the same thing in net-next's commit
f2798eb4e01b095f273f4bf40f511c9d69c0e1da.  If you queue to the backlog, the
backlog napi instance has no net device and so its null.  This is exactly the
right fix.

Thanks!
Neil

> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/