linux-kernel - Re: get_maintainers.pl & acer-wmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1261605542.1923.37.camel@Joe-Laptop.home>
Date:	Wed, 23 Dec 2009 13:59:02 -0800
From:	Joe Perches <joe@...ches.com>
To:	Carlos Corbacho <carlos@...angeworlds.co.uk>
Cc:	linville@...driver.com, linux-kernel@...r.kernel.org,
	len.brown@...el.com
Subject: Re: get_maintainers.pl & acer-wmi

On Wed, 2009-12-23 at 21:35 +0000, Carlos Corbacho wrote:
> Hi Joe,

Hi Carlos.

> We're getting some odd results out of get_maintainers.pl for acer-wmi.
> 
> ccorbacho@...ifica:~/src/kernel/linux-2.6$ perl scripts/get_maintainer.pl -f 
> drivers/platform/x86/acer-wmi.c
> 
> Carlos Corbacho <carlos@...angeworlds.co.uk>
> John W. Linville <linville@...driver.com>
> Len Brown <len.brown@...el.com>
> Alan Jenkins <alan-jenkins@...fmail.co.uk>
> Johannes Berg <johannes@...solutions.net>
> linux-kernel@...r.kernel.org
> 
> Which is odd, as I'm the only maintainer of acer-wmi, so why does it pull in 
> all the other names above?

You have git installed.

get_maintainer.pl by default uses git commit history and searches
for signatures.

These are people that have added "acked-by", "signed-off-by",
"reviewed-by" or any other "by" lines in the git commits.

$ ./scripts/get_maintainer.pl -f drivers/platform/x86/acer-wmi.c
Carlos Corbacho <carlos@...angeworlds.co.uk>
John W. Linville <linville@...driver.com>
Len Brown <len.brown@...el.com>
Alan Jenkins <alan-jenkins@...fmail.co.uk>
Johannes Berg <johannes@...solutions.net>
linux-kernel@...r.kernel.org

If you want to not use git history, add --nogit

$ ./scripts/get_maintainer.pl -f --nogit drivers/platform/x86/acer-wmi.c
Carlos Corbacho <carlos@...angeworlds.co.uk>
linux-kernel@...r.kernel.org

With the latest version of get_maintainer, you could add
--rolestats and see how many of the commits were signed
by each person.

$ ./scripts/get_maintainer.pl -f --rolestats drivers/platform/x86/acer-wmi.c
Carlos Corbacho <carlos@...angeworlds.co.uk> (maintainer:ACER WMI LAPTOP E...,commit_signer:4/11=36%)
John W. Linville <linville@...driver.com> (commit_signer:5/11=45%)
Len Brown <len.brown@...el.com> (commit_signer:4/11=36%)
Alan Jenkins <alan-jenkins@...fmail.co.uk> (commit_signer:3/11=27%)
Johannes Berg <johannes@...solutions.net> (commit_signer:2/11=18%)
linux-kernel@...r.kernel.org (open list)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/