linux-kernel - Re: [Patch] thinkpad_acpi: fix a build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Dec 2009 16:59:12 -0200
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Marcel Holtmann <marcel@...tmann.org>,
	Xiaotian Feng <xtfeng@...il.com>,
	Amerigo Wang <amwang@...hat.com>, linux-kernel@...r.kernel.org,
	Corentin Chary <corentincj@...aif.net>,
	ibm-acpi-devel@...ts.sourceforge.net,
	Len Brown <len.brown@...el.com>,
	Alan Jenkins <alan-jenkins@...fmail.co.uk>,
	akpm@...ux-foundation.org, helight.xu@...il.com
Subject: Re: [Patch] thinkpad_acpi: fix a build error

On Wed, 23 Dec 2009, Takashi Iwai wrote:
> At Tue, 22 Dec 2009 17:38:58 -0200,
> Henrique de Moraes Holschuh wrote:
> > I won't in this case. I think I will cook up a patch to disable the entire
> > mixer subsystem in thinkpad-acpi if CONFIG_SND is not available.  I don't
> > like the depends on SND though.
> 
> That's also not so trivial unless you give any dependency in Kconfig.
> Without a restriction, THINKPAD_ACPI=y and SND=m can be chosen.

"depends on SND || SND = n" takes care of the technical restrictions.

I am testing the patch now.  No ALSA, no volume subdriver, module still
works (and prints some crap to syslog so that the user knows the driver
could do more with ALSA support).

> It'd be also not nice if suddenly a certain functionality disappears
> without warning (even if the subsystem is enabled but as a module).

The warning will be there.  Although I don't warn of missing rfkill
functionality if the kernel is missing the rfkill subsystem...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/