linux-kernel - Re: [tip:sched/urgent] sched: Restore printk sanity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091225184514.GA381@elte.hu>
Date:	Fri, 25 Dec 2009 19:45:14 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Pavel Machek <pavel@....cz>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	joe@...ches.com, torvalds@...ux-foundation.org,
	peterz@...radead.org, efault@....de, akpm@...ux-foundation.org,
	tglx@...utronix.de, linux-tip-commits@...r.kernel.org,
	Alexander Viro <viro@....linux.org.uk>
Subject: Re: [tip:sched/urgent] sched: Restore printk sanity


* Pavel Machek <pavel@....cz> wrote:

> On Sun 2009-12-20 18:00:38, tip-bot for Peter Zijlstra wrote:
> > Commit-ID:  6c9a74afc5d95321e33a727b3c563f3e7d6c4a5c
> > Gitweb:     http://git.kernel.org/tip/6c9a74afc5d95321e33a727b3c563f3e7d6c4a5c
> > Author:     Peter Zijlstra <peterz@...radead.org>
> > AuthorDate: Sun, 20 Dec 2009 14:23:57 +0100
> > Committer:  Ingo Molnar <mingo@...e.hu>
> > CommitDate: Sun, 20 Dec 2009 18:45:57 +0100
> > 
> > sched: Restore printk sanity
> > 
> > Revert the braindead pr_* crap. (Commit 663997d "sched: Use
> > pr_fmt() and pr_<level>()")
> > 
> > It's dumb and causes stupid "sched: " strings all over the place.
> 
> It seems rest of kernel is moving towards pr_*. [...]

Git stats do not agree with you:

 - for every pr_*() line in the kernel source code there's more than 6
   printk's:

     $ git grep '\<pr_' | wc -l
     10861
     $ git grep '\<printk' | wc -l
     61126

 - in the last stable kernel, v2.6.32, still more new printk()s were 
   introduced than pr_*() lines:

     $ git log -p v2.6.31..v2.6.32 | grep '^+.*\<pr_' | wc -l
     2016
     $ git log -p v2.6.31..v2.6.32 | grep '^+.*\<printk' | wc -l
     3531

An estimated completion of the 'conversion' to pr_*() to be in infinite number 
of years.

> [...] just removing the "sched:" would be better for consistency.
> 
> Or alternatively... deprecate pr_*?

Or alternatively, my favorite: let people who write the code use whichever 
variant they prefer.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/