linux-kernel - Re: [PATCH] jbd: jbd-debug and jbd2-debug should be writable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091225204859.GG32757@thunk.org>
Date:	Fri, 25 Dec 2009 15:48:59 -0500
From:	tytso@....edu
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	"Yin, Kangkai" <kangkai.yin@...el.com>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] jbd: jbd-debug and jbd2-debug should be writable.

The ext4 portion has been added to the ext4 patch queue.

Jan, you want to add this to the ext3 tree?

					- Ted

jbd: /sys/kernel/debug/jbd/jbd-debug should be writable.

From: "Yin, Kangkai" <kangkai.yin@...el.com>

Make this sysfs file writeable so we can enable debugging without
needing to reboot and futzing with boot command-line option.

Signed-off-by: Yin Kangkai <kangkai.yin@...el.com>
Signed-off-by: "Theodore Ts'o" <tytso@....edu>
---
 fs/jbd/journal.c  |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c
index 4160afa..bd224ee 100644
--- a/fs/jbd/journal.c
+++ b/fs/jbd/journal.c
@@ -1913,7 +1913,7 @@ static void __init jbd_create_debugfs_entry(void)
 {
 	jbd_debugfs_dir = debugfs_create_dir("jbd", NULL);
 	if (jbd_debugfs_dir)
-		jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO,
+		jbd_debug = debugfs_create_u8("jbd-debug", S_IRUGO | S_IWUSR,
 					       jbd_debugfs_dir,
 					       &journal_enable_debug);
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/