lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Dec 2009 17:36:18 -0800 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Carlos Corbacho <carlos@...angeworlds.co.uk> Cc: Larry Finger <Larry.Finger@...inger.net>, Matthew Garrett <mjg@...hat.com>, LKML <linux-kernel@...r.kernel.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Linux ACPI <linux-acpi@...r.kernel.org> Subject: Re: Regression in module wmi since 2.6.32 (bisected to commit 1caab3c) Hi Carlos, On Sat, Dec 26, 2009 at 01:18:26AM +0000, Carlos Corbacho wrote: > @@ -747,6 +763,16 @@ static __init acpi_status parse_wdg(acpi_handle handle) > memcpy(gblock, obj->buffer.pointer, obj->buffer.length); > > for (i = 0; i < total; i++) { > + /* > + Some WMI devices, like those for nVidia hooks, have a > + duplicate GUID. It's not clear what we should do in this > + case yet, so for now, we'll just ignore the duplicate. > + Anyone who wants to add support for that device can come > + up with a better workaround for the mess then. > + */ > + if (guid_already_parsed(gblock[i].guid) == true) { A warning message is probably warranted here. > + continue; > + } > wblock = kzalloc(sizeof(struct wmi_block), GFP_KERNEL); > if (!wblock) > return AE_NO_MEMORY; -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists