linux-kernel - Re: [PATCH] kprobetrace: documentation fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B358B49.7080500@redhat.com>
Date:	Fri, 25 Dec 2009 23:04:25 -0500
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
CC:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] kprobetrace: documentation fix

KOSAKI Motohiro wrote:
> 
> shell interpret $val is as shell variable. thus we need quote if
> we use echo command.

Right.
Thank you for fixing!

> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>

Acked-by: Masami Hiramatsu <mhiramat@...hat.com>

> ---
>  Documentation/trace/kprobetrace.txt |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/trace/kprobetrace.txt b/Documentation/trace/kprobetrace.txt
> index 47aabee..2be6e19 100644
> --- a/Documentation/trace/kprobetrace.txt
> +++ b/Documentation/trace/kprobetrace.txt
> @@ -82,13 +82,13 @@ Usage examples
>  To add a probe as a new event, write a new definition to kprobe_events
>  as below.
>  
> -  echo p:myprobe do_sys_open dfd=$arg0 filename=$arg1 flags=$arg2 mode=$arg3 > /sys/kernel/debug/tracing/kprobe_events
> +  echo 'p:myprobe do_sys_open dfd=$arg0 filename=$arg1 flags=$arg2 mode=$arg3' > /sys/kernel/debug/tracing/kprobe_events
>  
>   This sets a kprobe on the top of do_sys_open() function with recording
>  1st to 4th arguments as "myprobe" event. As this example shows, users can
>  choose more familiar names for each arguments.
>  
> -  echo r:myretprobe do_sys_open $retval >> /sys/kernel/debug/tracing/kprobe_events
> +  echo 'r:myretprobe do_sys_open $retval' >> /sys/kernel/debug/tracing/kprobe_events
>  
>   This sets a kretprobe on the return point of do_sys_open() function with
>  recording return value as "myretprobe" event.

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/