linux-kernel - Re: [PATCH] parisc: test off by one in sgl_frem() and dbl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091227151047.15BE74EB5@hiauly1.hia.nrc.ca>
Date:	Sun, 27 Dec 2009 10:10:45 -0500 (EST)
From:	"John David Anglin" <dave@...uly1.hia.nrc.ca>
To:	roel.kluin@...il.com (Roel Kluin)
Cc:	kyle@...artin.ca, deller@....de, jejb@...isc-linux.org,
	linux-parisc@...r.kernel.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: test off by one in sgl_frem() and dbl_frem()

> With `while (stepcount-- > 0)' stepcount reaches -1 after the loop.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
>  arch/parisc/math-emu/dfrem.c |    2 +-
>  arch/parisc/math-emu/sfrem.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Unless I am missing something?

Are you sure the correct fix isn't to move the decrement of stepcount
into the loop?

Dave
-- 
J. David Anglin                                  dave.anglin@...-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/