linux-kernel - Re: [PATCH] [0/6] kfifo fixes/improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091228014141.GE2399@basil.fritz.box>
Date:	Mon, 28 Dec 2009 02:41:41 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Roland Dreier <rdreier@...co.com>
Cc:	Stefani Seibold <stefani@...bold.net>,
	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	akpm@...l.org
Subject: Re: [PATCH] [0/6] kfifo fixes/improvements

On Sun, Dec 27, 2009 at 04:12:06PM -0800, Roland Dreier wrote:
> 
>  > I am not happy to see you to take over my project. Especial as most of
>  > your fixes are part of my new macro based implementation. Have a look at
>  > http://patchwork.kernel.org/patch/69093/
> 
> I don't really understand.  You spent a lot of time getting the kfifo
> stuff merged, and now you want to merge (quoting from that patch above)
> "a complete reimplementation of the new kfifo API"?
> 
> What happened here?  Couldn't you have done the reimplementation before
> merging?

I guess the reimplementation came too late (happens sometimes)
And I agree that making kfifos record oriented makes sense.

Still now that the old one is in we have to fix it at least
until there are no users left.

-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/