lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Dec 2009 12:07:23 +0100 From: Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com> To: Peter Hüwe <PeterHuewe@....de> Cc: Haavard Skinnemoen <haavard.skinnemoen@...el.com>, Nicolas Ferre <nicolas.ferre@...el.com>, Haavard Skinnemoen <hskinnemoen@...el.com>, Andrew Morton <akpm@...ux-foundation.org>, Peter Ma <pma@...iamatech.com>, linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org Subject: Re: [PATCH] arch/avr32: Fix build failure for avr32 caused by typo On Mon, 28 Dec 2009 11:34:36 +0100 Peter Hüwe <PeterHuewe@....de> wrote: > Am Montag 28 Dezember 2009 11:20:28 schrieb Haavard Skinnemoen: > > Peter Hüwe <PeterHuewe@....de> wrote: > > > Great, thanks for the update. > > > The only thing that still catches my eye is that the kzalloc line can > > > fail, so you should perhaps add something like > > > if (!slave) { > > > printk(KERN_ERR "No memory left for at32ap700x: at32_add_device_mc"); > > > goto fail; > > > } > > > > I agree, except that this is extremely unlikely to happen, so we should > > either drop the printk() or use pr_debug() in order to waste as little > > memory as possible in production systems. > ok. > I skipped the print message, as no other platform devices will print similar information. If people really need this kind of information they could provide a patch adding it for all the platform devices. > > I think your first patch is good as it is, so I will apply it. Please > > send any additional fixes as a separate patch. > > Okay thanks for applying. > > @Hans: can you create the cleanup patch or should I ? > I'll do it, should arrive here shortly. -- Best regards, Hans-Christian Egtvedt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists