linux-kernel - Re: [PATCH 4/5] drivers/net/can: Correct NULL test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B38B786.9020609@hartkopp.net>
Date:	Mon, 28 Dec 2009 14:49:58 +0100
From:	Oliver Hartkopp <socketcan@...tkopp.net>
To:	Julia Lawall <julia@...u.dk>
CC:	Urs Thuermann <urs.thuermann@...kswagen.de>,
	Oliver Hartkopp <oliver.hartkopp@...kswagen.de>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org, chri <chripell@...il.com>,
	chripell@...lware.org
Subject: Re: [PATCH 4/5] drivers/net/can: Correct NULL test

Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>

Thanks Julia!

I added Christian Pellegrin who is the author of this driver in CC.

An obvious copy/paste error :-)

Regards,
Oliver

Acked-by: Oliver Hartkopp <oliver@...tkopp.net>

> 
> Test the just-allocated value for NULL rather than some other value.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression x,y;
> statement S;
> @@
> 
> x = \(kmalloc\|kcalloc\|kzalloc\)(...);
> (
> if ((x) == NULL) S
> |
> if (
> -   y
> +   x
>        == NULL)
>  S
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> ---
>  drivers/net/can/mcp251x.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -u -p a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c
> --- a/drivers/net/can/mcp251x.c
> +++ b/drivers/net/can/mcp251x.c
> @@ -990,7 +990,7 @@ static int __devinit mcp251x_can_probe(s
>  			goto error_tx_buf;
>  		}
>  		priv->spi_rx_buf = kmalloc(SPI_TRANSFER_BUF_LEN, GFP_KERNEL);
> -		if (!priv->spi_tx_buf) {
> +		if (!priv->spi_rx_buf) {
>  			ret = -ENOMEM;
>  			goto error_rx_buf;
>  		}
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/