linux-kernel - Re: [PATCH 1/2] [mmotm] Add notifiers for various swap events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091228192325.GG4994@basil.fritz.box>
Date:	Mon, 28 Dec 2009 20:23:25 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Andi Kleen <andi@...stfloor.org>, Nitin Gupta <ngupta@...are.org>,
	Hugh Dickins <hugh.dickins@...cali.co.uk>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] [mmotm] Add notifiers for various swap events

>>>> The first question to ask is if compressed swap is worth
>>>> it. Do you have benchmark numbers showing it to be an improvement?
>>>> Are there cases where it is slower than uncompressed swap?
>>>>
>>> http://code.google.com/p/compcache/wiki/Performance
>>
>> That should be included in the changelog of the patches.
>
> Which patches? The driver is already in staging and there's a pointer to 
> the home page in

How can it be in staging if there are no hooks for it yet?

>>> ramzswap is an optional module.
>>
>> I have some doubts on the wisdom of making swap algorithms modular.
>> Better compile them in. Then you don't need messy notifiers either.
>
> What's so messy about them? The whole point of having the notifiers is to 
> avoid CONFIG_RAMZSWAP in core kernel code...

They make the code much harder to read and follow. When you try to follow
the code flow and you find a notifier it's always a complicated operation
to figure out what code will end up being called.

Sometimes they are needed, but they have a high cost in maintainability.

-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/