linux-kernel - Re: [PATCH -mmotm-2009-12-10-17-19] Fix wrong rss count of smaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091228143154.ec0431b5.minchan.kim@barrios-desktop>
Date:	Mon, 28 Dec 2009 14:31:54 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	Minchan Kim <minchan.kim@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>, Matt Mackall <mpm@...enic.com>,
	Hugh Dickins <hugh.dickins@...cali.co.uk>
Subject: Re: [PATCH -mmotm-2009-12-10-17-19] Fix wrong rss count of smaps

Hi, Kame.

On Mon, 28 Dec 2009 13:47:52 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote:

> On Mon, 28 Dec 2009 13:46:19 +0900
> Minchan Kim <minchan.kim@...il.com> wrote:
> 
> > 
> > I am not sure we have to account zero page with file_rss. 
> > Hugh and Kame's new zero page doesn't do it. 
> > As side effect of this, we can prevent innocent process which have a lot
> > of zero page when OOM happens. 
> > (But I am not sure there is a process like this :)
> > So I think not file_rss counting is not bad. 
> > 
> > RSS counting zero page with file_rss helps any program using smaps?
> > If we have to keep the old behavior, I have to remake this patch. 
> > 
> > == CUT_HERE ==
> > 
> > Long time ago, We regards zero page as file_rss and
> > vm_normal_page doesn't return NULL.
> > 
> > But now, we reinstated ZERO_PAGE and vm_normal_page's implementation
> > can return NULL in case of zero page. Also we don't count it with
> > file_rss any more.
> > 
> > Then, RSS and PSS can't be matched.
> > For consistency, Let's ignore zero page in smaps_pte_range.
> > 
> > CC: Matt Mackall <mpm@...enic.com>
> > Signed-off-by: Minchan Kim <minchan.kim@...il.com>
> 
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>

Thanks for ACK. :)

> 
> BTW, how about counting ZERO page in smaps? Ignoring them completely sounds
> not very good.

I am not use it is useful. 

zero page snapshot of ongoing process is useful?
Doesn't Admin need to know about zero page?
Let's admins use it well. If we remove zero page again?
How many are applications use smaps? 
Did we have a problem without it?

When I think of it, there are too many qeustions. 
Most important thing to add new statistics is just need of customer. 

Frankly speaking, I don't have good scenario of using zero page.
Do you have any scenario it is valueable?

> 
> Thanks,
> -Kame



-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/