linux-kernel - Re: [PATCH] x86, perfctr: remove unused func avail_to_resrv_perfctr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091228083845.GK28652@elte.hu>
Date:	Mon, 28 Dec 2009 09:38:45 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	Naga Chumbalkar <nagananda.chumbalkar@...com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, oprofile-list@...ts.sf.net,
	tglx@...utronix.de
Subject: Re: [PATCH] x86, perfctr: remove unused func
 avail_to_resrv_perfctr_nmi()


* Cyrill Gorcunov <gorcunov@...il.com> wrote:

> On Thu, Dec 24, 2009 at 01:54:47AM +0000, Naga Chumbalkar wrote:
> > avail_to_resrv_perfctr_nmi() is neither EXPORT'd, nor used in the file.
> > So remove it.
> > 
> > Signed-off-by: Naga Chumbalkar <nagananda.chumbalkar@...com>
> > ---
> >  arch/x86/include/asm/nmi.h             |    1 -
> >  arch/x86/kernel/cpu/perfctr-watchdog.c |   11 -----------
> >  2 files changed, 0 insertions(+), 12 deletions(-)
> > 
> 
> Hi Naga, this looks good to me! Thanks.
> 
> Is there any plans to use this routine in future
> so we shouldn't touch this snippet?

Not that i know of.

In fact we should transform/migrate the NMI watchdog driver by making it based 
on a kernel-internal created perf event. (which is what the NMI watchdog 
really is: a periodic NMI event occuring once per second and running a 
callback function.)

That would give us NMI watchdog support on all future x86 CPUs, automatically 
- without having to extend the arch/x86/kernel/cpu/perfctr-watchdog.c code for 
it.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/