linux-kernel - Re: [Bug #14730] sky2 won't work after suspend/resume cycle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878wcltyg5.fsf@devron.myhome.or.jp>
Date:	Wed, 30 Dec 2009 03:41:30 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	"Maciej J. Woloszyk" <mat@....com.pl>
Subject: Re: [Bug #14730] sky2 won't work after suspend/resume cycle

"Rafael J. Wysocki" <rjw@...k.pl> writes:

> This message has been generated automatically as a part of a report
> of regressions introduced between 2.6.31 and 2.6.32.
>
> The following bug entry is on the current list of known regressions
> introduced between 2.6.31 and 2.6.32.  Please verify if it still should
> be listed and let me know (either way).
>
>
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=14730
> Subject		: sky2 won't work after suspend/resume cycle
> Submitter	: Maciej J. Woloszyk <mat@....com.pl>
> Date		: 2009-12-04 09:02 (26 days old)

This seems to be related to commit 4b77b0a2ba27d64f58f16d8d4d48d8319dda36ff.

It clears dev->state_saved blindly, but pci_pm_resume() calls
pci_restore_standard_config() before pm->resume() (by probably
historical reason).

So, I guess it became the cause of restore regression before changing
PCI power state. It might be better to revert
4b77b0a2ba27d64f58f16d8d4d48d8319dda36ff for now, until changing pci
generic stuff.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/