linux-kernel - Re: [RFC/PATCH] x86: Use KERN_DEFAULT log-level in __show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4B39B402.2040708@cs.helsinki.fi>
Date:	Tue, 29 Dec 2009 09:47:14 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Joe Perches <joe@...ches.com>, Ingo Molnar <mingo@...e.hu>,
	Vegard Nossum <vegard.nossum@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC/PATCH] x86: Use KERN_DEFAULT log-level in __show_regs()

Hi Joe,

[ I'm restoring CC, dunno if I broke accidentally. ]

Joe Perches kirjoitti:
> On Tue, 2009-12-29 at 09:08 +0200, Pekka Enberg wrote:
>> Joe Perches kirjoitti:
>>> What is the reason to convert KERN_INFO to KERN_DEFAULT here?
>> To be consistent with rest of __show_regs() log-levels.
> 
> What log level is DEFAULT?
> 
> It's default 4 or WARNING, but I'd guess you had to
> look to find it.
> 
> Does anyone override it?
> 
> Why not simply specify KERN_WARNING for all of them?

For the reasons outlined here:

> from:
> $ git log -1 e28d713704117bca0820c732210df6075b09f13b
> This adds a KERN_DEFAULT loglevel marker, for when you cannot decide
> which loglevel you want, and just want to keep an existing printk
> with the default loglevel.

The whole point of the patch is to unify 32-bit and 64-bit wrt 
log-levels. The 32-bit version _is_ using KERN_DEFAULT implicitly and 
KERN_INFO is arguably wrong which is why I decided to go with the 
former. That way I don't need to go and audit all the callers of 
__show_regs() to see if KERN_WARN or some other level makes sense for them.

			Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/