linux-kernel - Re: [PATCH 2/3] perf tools: remove pid option from stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B3B1D6C.8050006@windriver.com>
Date:	Wed, 30 Dec 2009 17:29:16 +0800
From:	Wang Liming <liming.wang@...driver.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] perf tools: remove pid option from stat

Ingo Molnar wrote:
> * Peter Zijlstra <peterz@...radead.org> wrote:
> 
>> On Tue, 2009-12-29 at 16:37 +0800, Liming Wang wrote:
>>> pid option is useless for stat, so remove it.
>> Hmm, it shouldn't be.. and instead of removing it I would suggesting fixing 
>> this.
> 
> Yes. For exampe something like:
> 
>   perf stat --repeat 10 --pid $(pidof firefox) sleep 1
> 
> Should show firefox's resource usage sampled over 10 seconds.
> 
> If this doesnt work it should be fixed. Plus i suspect we should allow:
> 
>   perf stat --pid $(pidof firefox)
> 
> to run until Ctrl-C - like perf record allows.
Yes, perf record works well with "--pid".
I think stat can borrow come code from record.
Please discard this patch.

Liming Wang
> 
> 	Ingo
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/