| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Pine.LNX.4.64.0912301228540.23134@ask.diku.dk> Date: Wed, 30 Dec 2009 12:29:20 +0100 (CET) From: Julia Lawall <julia@...u.dk> To: Joe Perches <joe@...ches.com> Cc: Rolf Eike Beer <eike-kernel@...tec.de>, James.Bottomley@...e.de, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 3/5] drivers/scsi : Correct the size argument to kmalloc On Tue, 29 Dec 2009, Joe Perches wrote: > On Tue, 2009-12-29 at 21:04 +0100, Julia Lawall wrote: > > On Tue, 29 Dec 2009, Rolf Eike Beer wrote: > > > Julia Lawall wrote: > > > > From: Julia Lawall <julia@...u.dk> > > > > In each case, the destination of the allocation has type struct **, so the > > > > elements of the array should have pointer type, not structure type. > > > Maybe they should even by kcalloc'ed? > > I thought about that, but in response to another patch someone seemed to > > think kcalloc was not very useful. But I can certainly change it in this > > case. > > I think kcalloc is useful and should be used when the > allocated array of elements needs to be zeroed. > > It appears the uses in 1/5 and 3/5 don't need it but > maybe patch 2/5 and 4/5 should use kcalloc. I will look into changing them too. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists