linux-kernel - Re: Q. d_alloc() in pipe(2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B3C14B2.8020902@tmr.com>
Date:	Wed, 30 Dec 2009 22:04:18 -0500
From:	Bill Davidsen <davidsen@....com>
To:	hooanon05@...oo.co.jp
CC:	viro@...IV.linux.org.uk, linux-kernel@...r.kernel.org
Subject: Re: Q. d_alloc() in pipe(2)

hooanon05@...oo.co.jp wrote:
> In pipe(2), create_write_pipe() creates a dentry by
> 	struct qstr name = { .name = "" };
> 	d_alloc(root, &name);
> 
> But d_alloc() refers name->len which is uninitialized.
> Isn't it better to replace d_alloc() by d_alloc_name(root, "")?
> 
If readability counts, I would say so. Functionally I don't know, I can't see 
any problems other than it's unobvious.

-- 
Bill Davidsen <davidsen@....com>
   "We have more to fear from the bungling of the incompetent than from
the machinations of the wicked."  - from Slashdot
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/