linux-kernel - Re: [PATCH 1/1] Constify struct kset_uevent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Dec 2009 20:40:39 -0800
From:	Greg KH <gregkh@...e.de>
To:	Emese Revfy <re.emese@...il.com>
Cc:	Pekka Enberg <penberg@...helsinki.fi>,
	linux-kernel@...r.kernel.org, rientjes@...gle.com,
	cl@...ux-foundation.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, rjw@...k.pl, rusty@...tcorp.com.au,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [PATCH 1/1] Constify struct kset_uevent_ops for 2.6.33-rc2

On Thu, Dec 31, 2009 at 01:16:58AM +0100, Emese Revfy wrote:
> Greg KH wrote:
> > On Tue, Dec 29, 2009 at 09:58:11PM +0100, Emese Revfy wrote:
> >>>> I double checked both the declaration and definitions of the affected
> >>>> function/structure and they are consistently const here.
> >>>> Can you tell me what patch/tree combination you encountered this
> >>>> warning with?
> >>> 2.6.33-rc2 with your patch.
> >> Here is the updated patch for 2.6.33-rc2 in one piece.
> >> Emese
> >>
> >>
> >> From: Emese Revfy <re.emese@...il.com>
> >>
> >> Constify struct kset_uevent_ops.
> > 
> > Why is this needed?  What does it accomplish?
> 
> This is my contribution to the ops structure constification effort
> that some developers started a few years ago (Arjan, Al Viro, etc.)
> and that has been worked on somewhat sporadically ever since. For a
> summary of why this is useful please see Arjan's email:
> http://lkml.org/lkml/2009/12/14/216

Then please insert this kind of information in the patch itself,
otherwise it is totally unknown.

Care to resend with the proper information in it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/