linux-kernel - Re: [patch staging] BCM70010 (crystalhd) Linux Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e4733911001021403n7ba076d0na423ae50e2983171@mail.gmail.com>
Date:	Sat, 2 Jan 2010 17:03:50 -0500
From:	Jon Smirl <jonsmirl@...il.com>
To:	Manu Abraham <abraham.manu@...il.com>
Cc:	Greg KH <greg@...ah.com>, Peter Paul <abnominales@....de>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch staging] BCM70010 (crystalhd) Linux Driver

On Sat, Jan 2, 2010 at 1:17 PM, Manu Abraham <abraham.manu@...il.com> wrote:
> Hi Greg,
>
> On Sat, Jan 2, 2010 at 8:34 PM, Greg KH <greg@...ah.com> wrote:
>> On Sat, Jan 02, 2010 at 08:05:38PM +0400, Manu Abraham wrote:
>>> Hi Greg,
>>>
>>> > I'm glad to do so if someone wants to help work on it there and shephard
>>> > it into the main kernel tree.
>>>
>>> Please find the initial round of cleaned up patches for staging,
>>> applied against linux-next.
>>
>> Did you really author this driver?  If so, that's fine, just checking.
>> If not, please put the correct authorship "From:" in the patch.
>
> I am not the author of the driver. I just picked it up and cleaned it
> up for Coding style changes for it to be included.

I'm not against this submission, but would it be better to wait until
Monday when the Broadcom authors are back as see if they want to
submit their own driver? That way changes would end up back in their
internal VCS.

I'd like to see a real datasheet for this chip, the public one is
nothing but a marketing blurb.


>
>> Also, please break up patches to be sent one-per-email so they can be
>> properly applied, and also only have them do one thing (your 4th patch
>> fixed up coding style issues and added the driver to the build.)
>
> Okay, I will resend them.
>
>> Also, can you add a TODO file to the driver directory stating what is
>> needed to be done, and who to contact about it?
>
> I will test the device over the coming week and add in a TODO after that.
>
> Thanks,
> Manu
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Jon Smirl
jonsmirl@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/