lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 03 Jan 2010 09:02:24 +0900
From:	Tejun Heo <>
To:	"Eric W. Biederman" <>
CC:	Greg KH <>,
	Linus Torvalds <>,
	KOSAKI Motohiro <>,
	Borislav Petkov <>,
	David Airlie <>,
	Linux Kernel Mailing List <>,
	Al Viro <>,
	Peter Zijlstra <>,
	Ingo Molnar <>
Subject: Re: [PATCH] sysfs: Add lockdep annotations for the sysfs active reference

On 01/03/2010 06:37 AM, Eric W. Biederman wrote:
> Holding locks over device_del -> kobject_del -> sysfs_deactivate can
> cause deadlocks if those same locks are grabbed in sysfs show or store
> methods.
> The I model s_active count + completion as a sleeping read/write lock.
> I describe to lockdep sysfs_get_active as a read_trylock,
> sysfs_put_active as a read_unlock, and sysfs_deactivate as a
> write_lock and write_unlock pair.  This seems to capture the essence
> for purposes of finding deadlocks, and in my testing gives finds real
> issues and ignores non-issues.
> This brings us back to holding locks over kobject_del is a problem
> that ideally we should find a way of addressing, but at least lockdep
> can tell us about the problems instead of requiring developers to debug
> rare strange system deadlocks, that happen when sysfs files are removed
> while being written to.
> Signed-off-by: Eric W. Biederman <>

Looks good to me.

Acked-by: Tejun Heo <>

Thanks for doing this.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists