linux-kernel - Re: regression: crash from 'ls /sys/modules/wl1251

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1262450062.2741.4.camel@mulgrave.site>
Date:	Sat, 02 Jan 2010 10:34:22 -0600
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	Kalle Valo <kalle.valo@....fi>, linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org, linux-omap@...r.kernel.org,
	Helge Deller <deller@....de>, rusty@...tcorp.com.au,
	akpm@...ux-foundation.org, roland@...hat.com,
	dave@...uly1.hia.nrc.ca, Parisc List <linux-parisc@...r.kernel.org>
Subject: Re: regression: crash from 'ls /sys/modules/wl1251_spi/notes'

On Fri, 2010-01-01 at 11:08 +0800, Américo Wang wrote:
> This patch looks fine for me, except that I don't think it's necessary
> to introduce an inline function for that...

Actually, I really think we do.  The whole reason we got into this mess
in the first place is that it wasn't obvious from the code that if we
altered the loadability of sections, there were a ton of dependent
places we also had to update.  Putting all that knowledge into a single
inline makes the same mistake impossible to make because there's now
only one place to go to adjust the loadability of sections, and it
automatically takes care of all the dependencies.

> Reviewed-by: WANG Cong <xiyou.wangcong@...il.com>

Thanks,

James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/