linux-kernel - Re: users of mod_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877hs0724u.fsf@basil.nowhere.org>
Date:	Sat, 02 Jan 2010 20:11:45 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: users of mod_timer_msec()

Arjan van de Ven <arjan@...radead.org> writes:

>  	emp->activity++;
>  	if (!timer_pending(&emp->timer))
> -		mod_timer(&emp->timer, jiffies + msecs_to_jiffies(10));
> +		mod_timer_msec(&emp->timer, 10);

... but your original patch does

+int mod_timer_msec(struct timer_list *timer, unsigned long delay_ms)
+{
+       return mod_timer(timer, msecs_to_jiffies(delay_ms));


That doesn't look equivalent.

mod_timer_msec should mod_timer_msec_plus_jiffies? 

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/