lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 Jan 2010 14:14:51 +0200 From: Dan Carpenter <error27@...il.com> To: Samuel Ortiz <sameo@...ux.intel.com> Cc: linux-kernel@...r.kernel.org Subject: [patch] off by one bug if irq == PCF50633_NUM_IRQ that puts us past the end of the array. Signed-off-by: Dan Carpenter <error27@...il.com> --- orig/drivers/mfd/pcf50633-core.c 2010-01-03 14:10:10.000000000 +0200 +++ devel/drivers/mfd/pcf50633-core.c 2010-01-03 14:10:31.000000000 +0200 @@ -217,7 +217,7 @@ static struct attribute_group pcf_attr_g int pcf50633_register_irq(struct pcf50633 *pcf, int irq, void (*handler) (int, void *), void *data) { - if (irq < 0 || irq > PCF50633_NUM_IRQ || !handler) + if (irq < 0 || irq >= PCF50633_NUM_IRQ || !handler) return -EINVAL; if (WARN_ON(pcf->irq_handler[irq].handler)) @@ -234,7 +234,7 @@ EXPORT_SYMBOL_GPL(pcf50633_register_irq) int pcf50633_free_irq(struct pcf50633 *pcf, int irq) { - if (irq < 0 || irq > PCF50633_NUM_IRQ) + if (irq < 0 || irq >= PCF50633_NUM_IRQ) return -EINVAL; mutex_lock(&pcf->lock); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists