linux-kernel - Re: [PATCH] drivers/infiniband/hw/cxgb3/iwch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 04 Jan 2010 09:08:51 -0600
From:	Steve Wise <swise@...ngridcomputing.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
CC:	linux-kernel@...r.kernel.org, swise@...lsio.com,
	Roland Dreier <rdreier@...co.com>
Subject: Re: [PATCH] drivers/infiniband/hw/cxgb3/iwch_cm.c: use %pM to show
 MAC address


Acked-by: Steve Wise <swise@...ngridcomputing.com>


H Hartley Sweeten wrote:
> Use the %pM kernel extension to display the MAC address.
>
> The only difference in the output is that the MAC address is
> shown in the usual colon-separated hex notation.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Steve Wise <swise@...lsio.com>
>
> ---
>
> diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
> index 66b4135..d94388b 100644
> --- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
> +++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
> @@ -1371,15 +1371,8 @@ static int pass_accept_req(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
>  	tim.mac_addr = req->dst_mac;
>  	tim.vlan_tag = ntohs(req->vlan_tag);
>  	if (tdev->ctl(tdev, GET_IFF_FROM_MAC, &tim) < 0 || !tim.dev) {
> -		printk(KERN_ERR
> -			"%s bad dst mac %02x %02x %02x %02x %02x %02x\n",
> -			__func__,
> -			req->dst_mac[0],
> -			req->dst_mac[1],
> -			req->dst_mac[2],
> -			req->dst_mac[3],
> -			req->dst_mac[4],
> -			req->dst_mac[5]);
> +		printk(KERN_ERR "%s bad dst mac %pM\n",
> +			__func__, req->dst_mac);
>  		goto reject;
>  	}
>   
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/