linux-kernel - Re: [PATCH] libsrp: fix compile failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1262633838.2724.218.camel@mulgrave.site>
Date:	Mon, 04 Jan 2010 13:37:17 -0600
From:	James Bottomley <James.Bottomley@...e.de>
To:	Stefani Seibold <stefani@...bold.net>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, Jiri Kosina <jkosina@...e.cz>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH] libsrp: fix compile failure

On Mon, 2010-01-04 at 20:24 +0100, Stefani Seibold wrote:
> Am Montag, den 04.01.2010, 17:35 +0000 schrieb Alan Cox:
> > > least once before it goes to Linus.  There were originally technical
> > > reasons why -mm wasn't in ... I just thought they'd been fixed by now.
> > 
> > No - mm also caused problems with the kfifo merge of a core API change
> > that didn't go via -next.
> > 
> > Alan
> 
> I tried my best to port everything to the new kfifo API. But it was not
> possible to check it against every architecture.

That's what linux-next is for:  to make at least this compile checking
against all of our architectures more of a reality.  It's still missing
bits, and some of the ports (*cough* parisc *cough*) compile against
linux-next rather infrequently, but it's far better than nothing.

>  x86 and x86_64 was
> compile clean. I think the missing #include was not a big thing.

It's easily fixable, yes ... breaking the build *is* a pretty big thing
because of the fallout it causes (for ppc: about ~100 instant WTF
moments followed by grubbing around in git to find the cause).

It's also an indicator of future problems.  Realistically, all API
changes should go into linux-next both to prevent this sort of thing
from happening and to see if we have any other pending conflicts that
may cause problems.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/