linux-kernel - Re: [PATCH] mm/page_alloc: fix the range check for backward merging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1001041302130.20593@chino.kir.corp.google.com>
Date:	Mon, 4 Jan 2010 13:02:17 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Kazuhisa Ichikawa <ki@...ilou.com>
cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/page_alloc: fix the range check for backward
 merging

On Sun, 3 Jan 2010, Kazuhisa Ichikawa wrote:

> From: Kazuhisa Ichikawa <ki@...ilou.com>
> 
> The current check for 'backward merging' within add_active_range()
> does not seem correct.  start_pfn must be compared against
> early_node_map[i].start_pfn (and NOT against .end_pfn) to find out
> whether the new region is backward-mergeable with the existing range.
> 
> Signed-off-by: Kazuhisa Ichikawa <ki@...ilou.com>
> ---
>  (This patch applies to linux-2.6.33-rc2)
> 
> --- a/mm/page_alloc.c	2009-12-25 06:09:41.000000000 +0900
> +++ b/mm/page_alloc.c	2010-01-03 19:20:36.000000000 +0900
> @@ -3998,7 +3998,7 @@ void __init add_active_range(unsigned in
>  		}
>  
>  		/* Merge backward if suitable */
> -		if (start_pfn < early_node_map[i].end_pfn &&
> +		if (start_pfn < early_node_map[i].start_pfn &&
>  				end_pfn >= early_node_map[i].start_pfn) {
>  			early_node_map[i].start_pfn = start_pfn;
>  			return;

Acked-by: David Rientjes <rientjes@...gle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/