linux-kernel - Re: [PATCH 1/1] atmel uaba : Adding invert vbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Jan 2010 08:54:11 +1100
From:	Ben Nizette <bn@...sdigital.com>
To:	Eirik Aanonsen <EAA@...medical.com>
Cc:	"kernel@...32linux.org" <kernel@...32linux.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] atmel uaba : Adding invert vbus_pin


On 05/01/2010, at 12:01 AM, Eirik Aanonsen wrote:

> Adding vbus_pin_inverted so that the usb detect pin can be active high or low.
> This because depending on HW implementation it is better to have active low.
> Also replaced the pio_get_value(udc->vbus_pin); with a call to vbus_is_present(udc);
> 
> Signed-off-by: Eirik Aanonsen <eaa@...medical.com>
> ---
> drivers/usb/gadget/atmel_usba_udc.c |   16 +++++++++++++---
> drivers/usb/gadget/atmel_usba_udc.h |    1 +
> include/linux/usb/atmel_usba_udc.h  |    1 +
> 3 files changed, 15 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
> index 4e970cf..1c469d4 100644
> --- a/drivers/usb/gadget/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/atmel_usba_udc.c
> @@ -320,8 +320,17 @@ static inline void usba_cleanup_debugfs(struct usba_udc *udc)
> static int vbus_is_present(struct usba_udc *udc)
> {
> 	if (gpio_is_valid(udc->vbus_pin))
> -		return gpio_get_value(udc->vbus_pin);
> -
> +	{	
> +		if(udc->vbus_pin_inverted)
> +		{
> +			if( gpio_get_value(udc->vbus_pin) == 1)
> +				return 0;
> +			else
> +				return 1;
> +		}
> +		else
> +			return gpio_get_value(udc->vbus_pin);
> +	}

return gpio_get_value(udc->vbus_pin) ^ udc->vbus_pin_inverted

	--Ben.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/