linux-kernel - Re: [PATCH] kernel/time/jiffies.c: local symbols should be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 04 Jan 2010 15:43:04 -0800
From:	john stultz <johnstul@...ibm.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/time/jiffies.c: local symbols should be static

On Mon, 2009-12-28 at 11:59 -0500, H Hartley Sweeten wrote:
> The symbol 'clocksource_jiffies' is not exported and should be static.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: John Stultz <johnstul@...ibm.com>

Yep, clocksource_jiffies has stopped being used elsewhere, so this can
be cleaned up.

Acked-by: John Stultz <johnstul@...ibm.com>

thanks
-john



> ---
> 
> diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
> index 5404a84..36d2d83 100644
> --- a/kernel/time/jiffies.c
> +++ b/kernel/time/jiffies.c
> @@ -55,7 +55,7 @@ static cycle_t jiffies_read(struct clocksource *cs)
>  	return (cycle_t) jiffies;
>  }
>  
> -struct clocksource clocksource_jiffies = {
> +static struct clocksource clocksource_jiffies = {
>  	.name		= "jiffies",
>  	.rating		= 1, /* lowest valid rating*/
>  	.read		= jiffies_read, 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/