[<prev] [next>] [day] [month] [year] [list]
Message-ID: <4B427D40.3010102@freemail.hu>
Date: Tue, 05 Jan 2010 00:44:00 +0100
From: Németh Márton <nm127@...email.hu>
To: Roger Lucas <vt8231@...denengine.co.uk>, lm-sensors@...sensors.org
CC: Julia Lawall <julia@...u.dk>, cocci@...u.dk,
LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH 2/5] vt8231: make PCI device id constant
From: Márton Németh <nm127@...email.hu>
The id_table field of the struct pci_driver is constant in <linux/pci.h>
so it is worth to make pci_device_id also constant.
The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier I1, I2, x;
@@
struct I1 {
...
const struct I2 *x;
...
};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
struct I1 y = {
.x = E,
};
@c@
identifier r.I2;
identifier s.E;
@@
const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const
struct I2 E[] = ...;
// </smpl>
Signed-off-by: Márton Németh <nm127@...email.hu>
Cc: Julia Lawall <julia@...u.dk>
Cc: cocci@...u.dk
---
diff -u -p a/drivers/hwmon/vt8231.c b/drivers/hwmon/vt8231.c
--- a/drivers/hwmon/vt8231.c 2009-12-03 04:51:21.000000000 +0100
+++ b/drivers/hwmon/vt8231.c 2010-01-03 20:55:14.000000000 +0100
@@ -697,7 +697,7 @@ static struct platform_driver vt8231_dri
.remove = __devexit_p(vt8231_remove),
};
-static struct pci_device_id vt8231_pci_ids[] = {
+static const struct pci_device_id vt8231_pci_ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8231_4) },
{ 0, }
};
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists