lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 05 Jan 2010 00:44:08 +0100 From: Németh Márton <nm127@...email.hu> To: Aurelien Jarno <aurelien@...el32.net>, lm-sensors@...sensors.org CC: Julia Lawall <julia@...u.dk>, cocci@...u.dk, LKML <linux-kernel@...r.kernel.org> Subject: [PATCH 4/5] sis5595: make PCI device id constant From: Márton Németh <nm127@...email.hu> The id_table field of the struct pci_driver is constant in <linux/pci.h> so it is worth to make pci_device_id also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ identifier I1, I2, x; @@ struct I1 { ... const struct I2 *x; ... }; @s@ identifier r.I1, y; identifier r.x, E; @@ struct I1 y = { .x = E, }; @c@ identifier r.I2; identifier s.E; @@ const struct I2 E[] = ... ; @depends on !c@ identifier r.I2; identifier s.E; @@ + const struct I2 E[] = ...; // </smpl> Signed-off-by: Márton Németh <nm127@...email.hu> Cc: Julia Lawall <julia@...u.dk> Cc: cocci@...u.dk --- diff -u -p a/drivers/hwmon/sis5595.c b/drivers/hwmon/sis5595.c --- a/drivers/hwmon/sis5595.c 2009-12-03 04:51:21.000000000 +0100 +++ b/drivers/hwmon/sis5595.c 2010-01-03 20:55:51.000000000 +0100 @@ -697,7 +697,7 @@ static struct sis5595_data *sis5595_upda return data; } -static struct pci_device_id sis5595_pci_ids[] = { +static const struct pci_device_id sis5595_pci_ids[] = { { PCI_DEVICE(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_503) }, { 0, } }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists