linux-kernel - Re: [PATCH -next] libs: force lzma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100103204230.a85ae137.randy.dunlap@oracle.com>
Date:	Sun, 3 Jan 2010 20:42:30 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Phillip Lougher <phillip@...gher.demon.co.uk>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Michal Marek <mmarek@...e.cz>, akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] libs: force lzma_wrapper to be retained

On Sun, 03 Jan 2010 00:55:55 +0000 Phillip Lougher wrote:

> Randy Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> > 
> > When CONFIG_SQUASHFS=m and CONFIG_DECOMPRESS_LZMA=m, decompress_lzma
> > is built but then discarded from the library because no built-in code
> > uses it, so change it from a lib- to an obj- to force it to be kept
> > in the library.
> > 
> > ERROR: "unlzma" [fs/squashfs/squashfs.ko] undefined!
> > 
> 
> Thanks for fixing this, I should have spotted it in my various
> config tests but didn't.  I could add this to my squashfs-next patches
> to stop the linux-next tree breakage, however, should it go into
> Michal's kbuild -next tree instead?

You can/should go ahead and include this patch, I think.

> This patch raises a small additional issue, why is DECOMPRESS_LZMA
> (and DECOMPRESS_GZIP/DECOMPRESS_BZIP2) and defined as tristate?
> None of the above compressors can be built as modules.

No idea.  Sounds like a potential problem.

> Regards
> 
> Phillip


---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/