lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Jan 2010 13:43:57 +0900 From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> To: Minchan Kim <minchan.kim@...il.com> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, Peter Zijlstra <peterz@...radead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>, cl@...ux-foundation.org, "hugh.dickins" <hugh.dickins@...cali.co.uk>, Nick Piggin <nickpiggin@...oo.com.au>, Ingo Molnar <mingo@...e.hu>, Linus Torvalds <torvalds@...ux-foundation.org> Subject: Re: [RFC][PATCH 6/8] mm: handle_speculative_fault() On Tue, 5 Jan 2010 13:29:40 +0900 Minchan Kim <minchan.kim@...il.com> wrote: > Hi, Kame. > > On Tue, Jan 5, 2010 at 9:25 AM, KAMEZAWA Hiroyuki > <kamezawa.hiroyu@...fujitsu.com> wrote: > > On Mon, 04 Jan 2010 19:24:35 +0100 > > Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote: > > > >> Generic speculative fault handler, tries to service a pagefault > >> without holding mmap_sem. > >> > >> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl> > > > > > > I'm sorry if I miss something...how does this patch series avoid > > that vma is removed while __do_fault()->vma->vm_ops->fault() is called ? > > ("vma is removed" means all other things as freeing file struct etc..) > > Isn't it protected by get_file and iget? > Am I miss something? > Only kmem_cache_free() part of following code is modified by the patch. == 229 static struct vm_area_struct *remove_vma(struct vm_area_struct *vma) 230 { 231 struct vm_area_struct *next = vma->vm_next; 232 233 might_sleep(); 234 if (vma->vm_ops && vma->vm_ops->close) 235 vma->vm_ops->close(vma); 236 if (vma->vm_file) { 237 fput(vma->vm_file); 238 if (vma->vm_flags & VM_EXECUTABLE) 239 removed_exe_file_vma(vma->vm_mm); 240 } 241 mpol_put(vma_policy(vma)); 242 kmem_cache_free(vm_area_cachep, vma); 243 return next; 244 } == Then, fput() can be called. The whole above code should be delayd until RCU glace period if we use RCU here. Then, my patch dropped speculative trial of page fault and did synchronous job here. I'm still considering how to insert some barrier to delay calling remove_vma() until all page fault goes. One idea was reference count but it was said not-enough crazy. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists