lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 05 Jan 2010 12:49:34 +0100 From: Andi Kleen <andi@...stfloor.org> To: ebiederm@...ssion.com (Eric W. Biederman) Cc: paulmck@...ux.vnet.ibm.com, akpm@...ux-foundation.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] [4/9] SYSCTL: Use RCU strings for core_pattern sysctl ebiederm@...ssion.com (Eric W. Biederman) writes: >> >> @@ -1421,7 +1421,7 @@ EXPORT_SYMBOL(set_binfmt); >> static int format_corename(char *corename, long signr) >> { >> const struct cred *cred = current_cred(); >> - const char *pat_ptr = core_pattern; >> + const char *pat_ptr = rcu_dereference(core_pattern); > > rcu_dereference should aways be between rcu_read_lock() > and rcu_read_unlock(); It is, see the call site below: >> - * lock_kernel() because format_corename() is controlled by sysctl, which >> - * uses lock_kernel() >> + * Protect corename by RCU vs proc_rcu_string() >> */ >> - lock_kernel(); >> + rcu_read_lock(); >> ispipe = format_corename(corename, signr); >> - unlock_kernel(); >> + rcu_read_unlock(); -Andi -- ak@...ux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists