linux-kernel - Re: [PATCH] [5/12] SYSFS: Add attribute array to sysdev classes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100105145433.GF11732@kroah.com>
Date:	Tue, 5 Jan 2010 06:54:33 -0800
From:	Greg KH <greg@...ah.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [5/12] SYSFS: Add attribute array to sysdev classes

On Tue, Jan 05, 2010 at 12:48:02PM +0100, Andi Kleen wrote:
> 
> Add a attribute array that is automatically registered and unregistered
> to struct sysdev_class. This is similar to what struct class has.
> 
> A lot of drivers add list of attributes, so it's better to do 
> this easily in the common sysdev layer.
> 
> This adds a new field to struct sysdev_class. I audited the 
> whole tree and there are no dynamically allocated sysdev classes,
> so this is fully compatible. 

I agree, this should be done, but can you use an attribute group
instead, like the driver core does?  That way you don't need the new
function that you created that duplicates that logic :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/