linux-kernel - Re: [PATCH] sparc: copy_from_user() should not return -EFAULT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201001051855.59100.arnd@arndb.de>
Date:	Tue, 5 Jan 2010 18:55:58 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Arjan van de Ven <arjan@...radead.org>,
	Ingo Molnar <mingo@...e.hu>,
	David Miller <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Chris Zankel <chris@...kel.net>
Subject: Re: [PATCH] sparc: copy_from_user() should not return -EFAULT

On Tuesday 05 January 2010, Heiko Carstens wrote:
> Subject: [PATCH] sparc: copy_from_user() should not return -EFAULT
> 
> From: Heiko Carstens <heiko.carstens@...ibm.com>
> 
> Callers of copy_from_user() expect it to return the number of bytes
> it could not copy. In no case it is supposed to return -EFAULT.
> 
> In case of a detected buffer overflow just return the requested
> length. In addition one could think of a memset that would clear
> the size of the target object.
> 
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>

The xtensa clear_user function seems to have a similar issue,
it should return size on failure, not -EFAULT.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/