linux-kernel - Re: [08/10] rt2x00: Disable powersaving for rt61pci and rt2800pci.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100105212122.GA32235@suse.de>
Date:	Tue, 5 Jan 2010 13:21:22 -0800
From:	Greg KH <gregkh@...e.de>
To:	Gertjan van Wingerde <gwingerde@...il.com>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	stable-review@...nel.org, Ivo van Doorn <IvDoorn@...il.com>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [08/10] rt2x00: Disable powersaving for rt61pci and rt2800pci.

On Tue, Jan 05, 2010 at 09:58:23PM +0100, Gertjan van Wingerde wrote:
> On 01/05/10 20:47, Greg KH wrote:
> > 2.6.27-stable review patch.  If anyone has any objections, please let us know.
> > 
> > ------------------
> > From: Gertjan van Wingerde <gwingerde@...il.com>
> > 
> > commit 93b6bd26b74efe46b4579592560f9f1cb7b61994 upstream.
> > 
> > We've had many reports of rt61pci failures with powersaving enabled.
> > Therefore, as a stop-gap measure, disable powersaving of the rt61pci
> > until we have found a proper solution.
> > Also disable powersaving on rt2800pci as it most probably will show
> > the same problem.
> > 
> > Signed-off-by: Gertjan van Wingerde <gwingerde@...il.com>
> > Acked-by: Ivo van Doorn <IvDoorn@...il.com>
> > Signed-off-by: John W. Linville <linville@...driver.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> > 
> > ---
> >  drivers/net/wireless/rt2x00/rt61pci.c |    5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > --- a/drivers/net/wireless/rt2x00/rt61pci.c
> > +++ b/drivers/net/wireless/rt2x00/rt61pci.c
> > @@ -2281,6 +2281,11 @@ static void rt61pci_probe_hw_mode(struct
> >  	unsigned int i;
> >  
> >  	/*
> > +	 * Disable powersaving as default.
> > +	 */
> > +	rt2x00dev->hw->wiphy->flags &= ~WIPHY_FLAG_PS_ON_BY_DEFAULT;
> > +
> > +	/*
> >  	 * Initialize all hw fields.
> >  	 */
> >  	rt2x00dev->hw->flags =
> > 
> > 
> > 
> 
> This one isn't applicable for .27. Powersaving wasn't implemented on .27 yet, so
> this patch is unnecessary, and won't compile on .27.

Thanks, I've now dropped it.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/