| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100105214524.GA31301@redhat.com> Date: Tue, 5 Jan 2010 23:45:24 +0200 From: "Michael S. Tsirkin" <mst@...hat.com> To: David Miller <davem@...emloft.net> Cc: cfriesen@...tel.com, eric.dumazet@...il.com, nhorman@...driver.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] net: packet: option to only pass skb protocol On Tue, Jan 05, 2010 at 01:42:18PM -0800, David Miller wrote: > From: "Chris Friesen" <cfriesen@...tel.com> > Date: Tue, 05 Jan 2010 15:28:22 -0600 > > > On 01/05/2010 12:57 PM, Michael S. Tsirkin wrote: > >> When sending packets with a packet socket it is often necessary to set > >> protocol in msg_name: otherwise the protocol field in the skb will not > >> be set correctly. > > > > What about automatically detecting the protocol from the data being sent > > to avoid the necessity of specifying it in the first place? > > This limits packet socket usage to only protocols the kernel is aware > of, defeating part of the usefulness of the packet socket facility. We could do this if the protocol is ETH_P_ALL - skbs end up with this protocol currently when sendmsg does not have msgname and when socket is set up to listen for all packets. It's not a valid protocol value, is it? -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists