[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4B444C39.3020901@linux.intel.com>
Date: Wed, 06 Jan 2010 16:39:21 +0800
From: Haicheng Li <haicheng.li@...ux.intel.com>
To: Pekka Enberg <penberg@...helsinki.fi>
CC: Christoph Lameter <cl@...ux-foundation.org>, linux-mm@...ck.org,
Matt Mackall <mpm@...enic.com>,
Andi Kleen <andi@...stfloor.org>,
Eric Dumazet <eric.dumazet@...il.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] slab: initialize unused alien cache entry as NULL
at alloc_alien_cache().
Pekka Enberg wrote:
> I can find a trace of Andi acking the previous version of this patch
> but I don't see an ACK from Christoph nor a revieved-by from Matt. Was
> I not CC'd on those emails or what's going on here?
>
Pekka,
Christoph said he will ack this patch if remove the change of MAX_NUMNODES (see below),
so I add him directly as Acked-by in this revised patch. And also, I got review
comments from Matt for v1 and changed the patch accordingly.
Is it a violation of the rule? if so, I'm sorry, actually not quite clear with the rule.
Christoph Lameter wrote:
> On Wed, 23 Dec 2009, Haicheng Li wrote:
>
>> @@ -966,18 +966,16 @@ static void *alternate_node_alloc(struct kmem_cache *,
>> gfp_t);
>> static struct array_cache **alloc_alien_cache(int node, int limit, gfp_t gfp)
>> {
>> struct array_cache **ac_ptr;
>> - int memsize = sizeof(void *) * nr_node_ids;
>> + int memsize = sizeof(void *) * MAX_NUMNODES;
>> int i;
>
> Remove this change and I will ack the patch.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists