linux-kernel - Re: [PATCH v3] slab: initialize unused alien cache entry as NULL at alloc_alien

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B444DE8.1040609@linux.intel.com>
Date:	Wed, 06 Jan 2010 16:46:32 +0800
From:	Haicheng Li <haicheng.li@...ux.intel.com>
To:	Pekka Enberg <penberg@...helsinki.fi>
CC:	Christoph Lameter <cl@...ux-foundation.org>, linux-mm@...ck.org,
	Matt Mackall <mpm@...enic.com>,
	Andi Kleen <andi@...stfloor.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] slab: initialize unused alien cache entry as NULL
 at 	alloc_alien_cache().

understood. thanks!

Pekka Enberg wrote:
> Hi,
> 
> Haicheng Li wrote:
>> Pekka Enberg wrote:
>>  > I can find a trace of Andi acking the previous version of this patch
>>  > but I don't see an ACK from Christoph nor a revieved-by from Matt. Was
>>  > I not CC'd on those emails or what's going on here?
>>  >
>>
>> Christoph said he will ack this patch if remove the change of 
>> MAX_NUMNODES (see below),
>> so I add him directly as Acked-by in this revised patch. And also, I 
>> got review
>> comments from Matt for v1 and changed the patch accordingly.
>>
>> Is it a violation of the rule? if so, I'm sorry, actually not quite 
>> clear with the rule.
> 
> See Section 14 of Documentation/SubmittingPatches. You should never add 
> tags unless they came from the said person. The ACKs from Andi is fine, 
> the one from Christoph is borderline but OK and the one from Matt is 
> _not_ OK.
> 
> I can fix those up but I'll wait from an explicit ACK from Christoph first.
> 
>                         Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/