linux-kernel - [bisected] drm/ksm: fbdev blanking regression in 2.6.33

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1262797226-9593-1-git-send-email-jhovold@gmail.com>
Date:	Wed,  6 Jan 2010 18:00:25 +0100
From:	Johan Hovold <jhovold@...il.com>
To:	Dave Airlie <airlied@...hat.com>
Cc:	James Simmons <jsimmons@...radead.org>,
	dri-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: [bisected] drm/ksm: fbdev blanking regression in 2.6.33

Hi,

Console blanking broke on my laptop with GM45 chipset with 2.6.33. Instead of
blanking, the screen was dimmed and the backlight started glowing in the lower
edges of the screen. The glowing then slowly spread upwards. Did not look
healthy at all.

Easily reproduced by issuing "setterm -blank force".

I bisected it down to 731b5a15a3b1474a41c2ca29b4c32b0f21bc852e (drm/kms:
properly handle fbdev blanking). Which instead of going directly to
DPMS_STANDBY now calls the encoder dpms helper with DRM_MODE_DPMS_ON and the
crtc dpms helper with DRM_MODE_DPMS_OFF. I've verified that is this combination
that triggers the bug. 

If I don't call crtc_funcs->dpms(crtc, DRM_MODE_DPMS_OFF) on FB_BLANK_NORMAL
but still encoder_funcs->dpms(encoder, DRM_MODE_DPMS_ON), the bug is not
triggered, but the screen is not cleared either.

For now, I simply reverted to the old behaviour of going directly to
DPMS_STANDBY (see follow-up patch).  

Thanks,
Johan

Johan Hovold (1):
  drm/kms: fix fbdev blanking regression

 drivers/gpu/drm/drm_fb_helper.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/