linux-kernel - Re: [PATCH 1/1] cred: fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20320.1262797603@redhat.com>
Date:	Wed, 06 Jan 2010 17:06:43 +0000
From:	David Howells <dhowells@...hat.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	dhowells@...hat.com, jmorris@...ei.org,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, jirislaby@...il.com,
	Serge Hallyn <serue@...ibm.com>
Subject: Re: [PATCH 1/1] cred: fix memory leak

Jiri Slaby <jslaby@...e.cz> wrote:

> Stanse found a memory leak in prepare_exec_creds. tgcred is not
> freed/assigned on all paths. Fix that.
> 
> I.e. unifdef tgcred and add kfree(tgcred); as it is initialized to
> NULL already.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: David Howells <dhowells@...hat.com>
> Cc: James Morris <jmorris@...ei.org>
> Cc: Serge Hallyn <serue@...ibm.com>

Acked-by: David Howells <dhowells@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/