linux-kernel - Re: [PATCH 2/7] Export unusable free space index via /proc/pagetypeinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100106172945.GA5426@csn.ul.ie>
Date:	Wed, 6 Jan 2010 17:29:45 +0000
From:	Mel Gorman <mel@....ul.ie>
To:	Adam Litke <agl@...ibm.com>
Cc:	Andrea Arcangeli <aarcange@...hat.com>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Avi Kivity <avi@...hat.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH 2/7] Export unusable free space index via
	/proc/pagetypeinfo

On Wed, Jan 06, 2010 at 11:10:48AM -0600, Adam Litke wrote:
> On Wed, 2010-01-06 at 16:26 +0000, Mel Gorman wrote:
> > +/*
> > + * Return an index indicating how much of the available free memory is
> > + * unusable for an allocation of the requested size.
> > + */
> > +int unusable_free_index(struct zone *zone,
> > +				unsigned int order,
> > +				struct config_page_info *info)
> > +{
> > +	/* No free memory is interpreted as all free memory is unusable */
> > +	if (info->free_pages == 0)
> > +		return 100;
> 
> Should the above be 1000?
> 

Yes. Fortunately, the value is not actually used by any of the code.
It's for consumption by people or tools.

Thanks

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/